Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle should not start a new list entry #1212

Merged
merged 1 commit into from Sep 20, 2023

Conversation

bobh66
Copy link
Contributor

@bobh66 bobh66 commented Sep 18, 2023

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind documentation

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #1211

This fixes an issue where the bundle attribute was starting a new list entry and cutting off any provided chart information which is needed for extracting the tar file into a specific filename.

Also updated the documentation example and values.yaml files to provide more information on the init helm chart entries.

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster could not apply more than one bundled helm chart.

What else do we need to know?
The init code assumes that the chart.name, chart.repo and chart.version are populated for both bundle and repo charts. The repo is not technically needed for bundled charts and the filename can be generated without it. Requiring the name and version for a bundled chart may seem a little odd, but it's the way the tar file name is determined, so unless that code gets refactored the chart.name and chart.version should be specified even for bundled charts.

Copy link
Member

@ThomasK33 ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bobh66 👋

Thanks for the PR, LGTM

@ThomasK33 ThomasK33 merged commit 71fa9d9 into loft-sh:main Sep 20, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled chart deployment fails for more than one bundled chart
2 participants