fix: watch and enqueue node events when scheduler enabled #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated description |
rohantmp
force-pushed
the
fixNodeSyncingScheduler
branch
from
e23edb0
to
8273c96
Compare
|
cleaned up some comments, removed a debug statement |
FabianKramm
requested changes
Nov 13, 2023
rohantmp
force-pushed
the
fixNodeSyncingScheduler
branch
from
8273c96
to
ed4c781
Compare
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
rohantmp
force-pushed
the
fixNodeSyncingScheduler
branch
from
ed4c781
to
1a51cf3
Compare
FabianKramm
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using the vcluster scheduler we take into account consumed resources in the pod, but don't immediately trigger the node syncer to do this. This sometimes leads to scheduling resources onto nodes where they don't fit.
Signed-off-by: Rohan CJ rohantmp@gmail.com
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind enhancement
/kind feature
/kind documentation
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-2340
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster scheduler was late to see resource consumption
What else do we need to know?