Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create clusterrole and pod permissions when coredns plugin enabled #1356

Merged

Conversation

ishankhare07
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-2307

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster.Pro was missing clusterrole permission to get pods for other vclusters as targets

What else do we need to know?

Signed-off-by: Ishan Khare <me@ishankhare.dev>
@ishankhare07 ishankhare07 marked this pull request as ready for review November 16, 2023 11:07
@FabianKramm FabianKramm merged commit 5ec0550 into loft-sh:main Nov 16, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants