k0s is now run from the syncer container #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchettos
force-pushed
the
k0s-in-syncer
branch
from
7dab534
to
99a2d15
Compare
FabianKramm
requested changes
Nov 28, 2023
FabianKramm
requested changes
Nov 28, 2023
| - name: tmp | ||
| mountPath: /tmp | ||
| {{- if .Values.coredns.enabled }} | ||
| - name: coredns | ||
| mountPath: /manifests/coredns | ||
| readOnly: true | ||
| {{- end }} | ||
| {{ toYaml .Values.syncer.volumeMounts | indent 10 }} | ||
| {{- if .Values.syncer.extraVolumeMounts }} |
There was a problem hiding this comment.
Just add the .Values.vcluster.volumeMounts here
facchettos
force-pushed
the
k0s-in-syncer
branch
from
95d2f90
to
deae0f6
Compare
facchettos
force-pushed
the
k0s-in-syncer
branch
from
deae0f6
to
8ebf06b
Compare
FabianKramm
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves eng-2478
Please provide a short message that should be published in the vcluster release notes
k0s is now run from inside the syncer container
What else do we need to know?