New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added draft for interceptor plugin #1612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
facchettos
force-pushed
the
plugin-interceptor
branch
from
March 27, 2024 08:06
2bc9d5b
to
9d85e84
Compare
facchettos
force-pushed
the
plugin-interceptor
branch
from
March 27, 2024 14:54
9e376ba
to
92ee3fa
Compare
ThomasK33
previously requested changes
Apr 2, 2024
facchettos
force-pushed
the
plugin-interceptor
branch
3 times, most recently
from
April 3, 2024 07:45
ff993b8
to
8dc9447
Compare
facchettos
force-pushed
the
plugin-interceptor
branch
from
April 3, 2024 08:34
53d2f4d
to
089291f
Compare
FabianKramm
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@facchettos great work, looks great! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)part of eng-3064
Please provide a short message that should be published in the vcluster release notes
add new methods to the plugin lib so that we can intercept requests for complex uses cases
What else do we need to know?