feat: add "migrate values" command to migrate to new values format #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
|
Maybe we should make |
johannesfrey
force-pushed
the
vcluster-migrate
branch
from
032abc7
to
2056fbb
Compare
heiko-braun
reviewed
Apr 11, 2024
johannesfrey
force-pushed
the
vcluster-migrate
branch
from
5e50e20
to
33f151a
Compare
johannesfrey
commented
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Resolves ENG-3274
Please provide a short message that should be published in the vcluster release notes
Add "migrate values" command to vcluster in order to convert the old values format to the new format introduced with 0.20
What else do we need to know?
Current caveat is that the passed in values actually match
--distro. Otherwise theMigrateLegacyConfigcurrently will simply create new default values for the given distro in the new format. So I made--distromandatory with a warning that it should exactly match the provided values.