Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add image.registry to configure registry separately #1747

Merged
merged 1 commit into from
May 8, 2024

Conversation

FabianKramm
Copy link
Member

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-3634

Copy link

netlify bot commented May 7, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit 432f21c
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/663a41463e735b000868b0fb

@FabianKramm FabianKramm force-pushed the main branch 2 times, most recently from 0b3707c to dee0116 Compare May 7, 2024 13:31
Copy link
Contributor

@johannesfrey johannesfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit and a question.

config/legacyconfig/migrate_test.go Show resolved Hide resolved
chart/tests/statefulset_test.yaml Show resolved Hide resolved
@FabianKramm FabianKramm merged commit b858d36 into loft-sh:main May 8, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants