Adds enableServiceLinks to the STS config for controlPlane and controlPlane.backingStore #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lPlane.backingStore
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
reviewed
May 22, 2024
FabianKramm
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind test
What does this pull request do? Which issues does it resolve?
resolves ENG-3500
resolves #1708
Please provide a short message that should be published in the vcluster release notes
Added the ability to disable service links for the etcd STS as they can cause problems in a cluster with thousands of services.
What else do we need to know?
vcluster.yaml docs should be updated as well.
👇 Demo showing creating one vCluster for each of the new
enableServiceLinksconfig options. Then getting the STS yaml, and parsing out the value that should, and does, read false in both cases: