Allow multiple-vcluster-creation in a single namespace #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d existing check to prevent namespace deletion incase another vcluster is running in the same namespace
mahendrabagul
force-pushed
the
remove-single-vc-check-per-namespace
branch
from
f112d1a
to
b5e137c
Compare
FabianKramm
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and corrected existing check to prevent namespace deletion incase another vcluster is running in the same namespace.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves # Regression of earlier fix
Please provide a short message that should be published in the vcluster release notes
Allow multiple-vcluster-creation in a single namespace. If a vcluster is deleted and another vcluster is running in the same namespace, namespace won't be deleted.
What else do we need to know?