Make it Compatible with Python3 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelyatin
force-pushed
the
python3
branch
2 times, most recently
from
1225253
to
d068917
Compare
Some code syntax is not compatible with python3, this patch
fixes makes it compatible for both python 2 and 3.
Following changes are done:
- except Exception, e => except Exception as e
- raise Error, "MSG" => raise Error("MSG")
- print "MSG" => print("MSG")
- use builtins.int to coverup long in python 2
- use past.builtins.basestring to coverup basestring in python 3
- d.itervalues() => iter(d.values())
- d.iteritems() => iter(d.items())
- d.iterkeys() => iter(d.keys())
- using 'in' in place of 'has_key'
|
stale PR for too long, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception, print Syntax is not compatible with python3, this patch
fixes it. Following changes are done: