Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added data slice helper #403

Merged
merged 1 commit into from Jul 13, 2019
Merged

Added data slice helper #403

merged 1 commit into from Jul 13, 2019

Conversation

joachimmetz
Copy link
Member

Added data slice helper

@joachimmetz joachimmetz requested a review from Onager July 12, 2019 09:31
@joachimmetz joachimmetz force-pushed the fslice branch 2 times, most recently from c001d38 to 9488232 Compare July 12, 2019 11:24
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #403 into master will decrease coverage by 0.04%.
The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   88.48%   88.44%   -0.05%     
==========================================
  Files         207      208       +1     
  Lines        9762     9797      +35     
==========================================
+ Hits         8638     8665      +27     
- Misses       1124     1132       +8
Impacted Files Coverage Δ
dfvfs/helpers/data_slice.py 77.14% <77.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a925ffb...9488232. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 12, 2019 •
edited

Codecov Report

Merging #403 into master will decrease coverage by 0.04%.
The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   88.48%   88.44%   -0.05%     
==========================================
  Files         207      208       +1     
  Lines        9762     9797      +35     
==========================================
+ Hits         8638     8665      +27     
- Misses       1124     1132       +8
Impacted Files Coverage Δ
dfvfs/helpers/data_slice.py 77.14% <77.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a925ffb...e3b7d7d. Read the comment docs.

Onager
Onager approved these changes Jul 12, 2019
View reviewed changes
dfvfs/helpers/data_slice.py Outdated

def __exit__(self, unused_type, unused_value, unused_traceback):
"""Exits a with statement."""
# TODO: do we want to close the file_object here e.g. i.c.w. a flag value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite "e.g. i.c.w". Also, I don't think we want to close the file object here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, I've removed the comment.

@joachimmetz joachimmetz added to merge Issue has been reviewed and can be merged and removed to merge Issue has been reviewed and can be merged labels Jul 12, 2019
@joachimmetz joachimmetz merged commit 2665f4f into log2timeline:master Jul 13, 2019
@joachimmetz joachimmetz deleted the fslice branch July 13, 2019 06:42
@joachimmetz joachimmetz mentioned this pull request Jul 13, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Onager Onager Onager approved these changes

Assignees

@Onager Onager

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joachimmetz @Onager