Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing extra test file, removing old tests. #36

Merged
merged 3 commits into from
Oct 4, 2018

Conversation

kiddinn
Copy link
Member

@kiddinn kiddinn commented Sep 28, 2018

Removing extra test file, removing old tests.

@kiddinn kiddinn requested review from Onager and removed request for joachimmetz September 28, 2018 11:26
@kiddinn kiddinn assigned Onager and kiddinn and unassigned joachimmetz Sep 28, 2018
@kiddinn kiddinn added the bug label Sep 28, 2018
@kiddinn
Copy link
Member Author

kiddinn commented Sep 28, 2018

Travis tests were failing time and time again on old test files that are about to be deleted from the codebase, disabling these tests for now.

@kiddinn kiddinn added this to In Review in scaffolder v2 Sep 28, 2018
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #36 into master will decrease coverage by 66.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #36       +/-   ##
===========================================
- Coverage   97.03%   30.79%   -66.24%     
===========================================
  Files          61       61               
  Lines        1552     1552               
===========================================
- Hits         1506      478     -1028     
- Misses         46     1074     +1028
Impacted Files Coverage Δ
...affolder/bll/services/base_sqlite_plugin_helper.py 0% <0%> (-100%) ⬇️
plasoscaffolder/common/base_file_handler.py 0% <0%> (-100%) ⬇️
plasoscaffolder/model/formatter_data_model.py 0% <0%> (-100%) ⬇️
plasoscaffolder/dal/base_type_helper.py 0% <0%> (-100%) ⬇️
plasoscaffolder/common/output_handler_click.py 0% <0%> (-100%) ⬇️
...asoscaffolder/model/sql_query_column_model_data.py 0% <0%> (-100%) ⬇️
...affolder/model/sql_query_column_model_timestamp.py 0% <0%> (-100%) ⬇️
...affolder/bll/mappings/base_sqliteplugin_mapping.py 0% <0%> (-100%) ⬇️
plasoscaffolder/bll/services/sqlite_generator.py 0% <0%> (-100%) ⬇️
plasoscaffolder/model/init_data_model.py 0% <0%> (-100%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3baaa22...590d937. Read the comment docs.

@Onager Onager merged commit 81436c1 into log2timeline:master Oct 4, 2018
@kiddinn kiddinn deleted the fix_test branch October 19, 2018 13:16
@kiddinn kiddinn moved this from In Review to Done in scaffolder v2 Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
scaffolder v2
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants