Create the frontend to the scaffolder project #40

kiddinn · 2018-10-20T03:34:57Z

Adding the front-end and tools to the scaffolder project.

plasoscaffolder/frontend/cli.py

plasoscaffolder/frontend/cli_output_handler.py

plasoscaffolder/frontend/frontend.py

plasoscaffolder/frontend/output_handler.py

kiddinn

this round is done

plasoscaffolder/frontend/cli_output_handler.py

kiddinn · 2018-11-12T16:30:35Z

plasoscaffolder/frontend/cli_output_handler.py

+    click.secho(text, fg='cyan')
+
+  def PrintNewLine(self):
+    """A new line added to output."""


again, hopefully at least somewhat better

kiddinn · 2018-11-12T16:32:31Z

plasoscaffolder/frontend/frontend.py

+
+  @classmethod
+  def _AskDictQuestion(
+      cls, question: scaffolder_interface.BaseQuestion) -> Dict[str, Type]:


kiddinn · 2018-11-12T16:37:54Z

plasoscaffolder/frontend/frontend.py

+  @classmethod
+  def _AskDictQuestion(
+      cls, question: scaffolder_interface.BaseQuestion) -> Dict[str, Type]:
+    """Ask the user a question and return a dict answer back.


kiddinn · 2018-11-12T16:39:19Z

plasoscaffolder/frontend/frontend.py

+      question (scaffolder_interface.BaseQuestion): the question to ask.
+
+    Returns:
+      dict: the answer as supplied by the user.


plasoscaffolder/frontend/frontend.py

kiddinn · 2018-11-13T12:18:25Z

ready for another round of review

…e#41) * Adding a TS analyzer scaffolders. * Adding templates. * Adding test files. * minor linter errors. * responding to comments. * Update plasoscaffolder/templates/ts_sketch_analyzer.jinja2 Co-Authored-By: kiddinn <kristinn@log2timeline.net> * Update plasoscaffolder/templates/ts_sketch_analyzer.jinja2 Co-Authored-By: kiddinn <kristinn@log2timeline.net> * Update plasoscaffolder/templates/ts_sketch_analyzer.jinja2 Co-Authored-By: kiddinn <kristinn@log2timeline.net>

Onager

A few more nits, and I've made some small fixups, so please remember to git pull.

Looking at this more closely, I'm not thrilled about having all the frontend logic implemented as class methods vs normal methods. I'm also confused as to why the cli is implemented as an option callback instead of a normal click command.

Can you explain these choices, or refactor?

plasoscaffolder/frontend/output_handler.py

plasoscaffolder/helpers/git.py

tools/l2t_scaffolder.py

plasoscaffolder/frontend/frontend.py

tools/l2t_scaffolder.py

kiddinn

so to explain choice of option callback vs. normal click command -> legacy, that's how it was done in the original tool.

That design choice necessitated that all functions in the frontend to be a classmethod. I just changed this to not be that way, that is use the regular click command instead, and then I Could refactor all classmethods to be just instance methods.

plasoscaffolder/frontend/output_handler.py

plasoscaffolder/helpers/git.py

tools/l2t_scaffolder.py

kiddinn · 2018-11-20T17:00:26Z

ready for another round

plasoscaffolder/helpers/git.py

plasoscaffolder/scaffolders/__init__.py

plasoscaffolder/frontend/frontend.py

Onager · 2018-11-21T10:40:29Z

plasoscaffolder/frontend/frontend.py

+      question (scaffolder_interface.BaseQuestion): the question to ask.
+
+    Returns:
+      dict: the answer as supplied by the user.


I think that'll be overkill. Added something here.

kiddinn · 2018-11-21T11:24:15Z

done

requirements.txt

kiddinn · 2018-11-21T15:07:49Z

removed the timeout

kiddinn added 7 commits September 28, 2018 05:37

Adding the frontend, frontend output handler and changing setup.

d7555b6

Adding CLI

0f29884

Merge branch 'master' into cli_cl

684cf07

Minor bug in frontend.

0304787

deleting an old test.

d9a66c2

adding tests.

ed64386

Fixing linter issues.

581b671

kiddinn assigned Onager and kiddinn Oct 20, 2018

kiddinn requested a review from Onager October 20, 2018 03:34

merging

938ee63

kiddinn mentioned this pull request Oct 23, 2018

Remove old code from the project #37

Closed

kiddinn added this to In Review in scaffolder v2 Oct 23, 2018

Onager requested changes Oct 30, 2018

View reviewed changes

kiddinn commented Nov 13, 2018

View reviewed changes

Updating code after code review.

95774b8

kiddinn requested a review from Onager November 13, 2018 12:18

kiddinn mentioned this pull request Nov 13, 2018

Adding index and sketch analyzer plugins for Timesketch. #41

Merged

kiddinn added 2 commits November 13, 2018 08:00

Minor change to error handling.

54dcb13

kiddinn mentioned this pull request Nov 19, 2018

Update CLI to work with new updates. #30

Closed

kiddinn added the enhancement label Nov 19, 2018

kiddinn mentioned this pull request Nov 19, 2018

Rename the github project l2t_scaffolder #43

Closed

Changes after review

7f079f1

Onager requested changes Nov 20, 2018

View reviewed changes

kiddinn added 4 commits November 20, 2018 07:32

Adding the frontend, frontend output handler and changing setup.

687ea4a

Adding CLI

db74419

Minor bug in frontend.

cc8b140

.

5436d22

kiddinn and others added 7 commits November 20, 2018 07:34

Fixing linter issues.

65074d7

Updating code after code review.

0c64547

Minor change to error handling.

5ba8503

Changes after review

453d74f

Responding to code reviews.

4abb96e

Responding to code reviews.

178f683

Merge issues.

55e14a4

kiddinn commented Nov 20, 2018

View reviewed changes

plasoscaffolder/frontend/output_handler.py Outdated Show resolved Hide resolved

plasoscaffolder/helpers/git.py Outdated Show resolved Hide resolved

plasoscaffolder/helpers/git.py Outdated Show resolved Hide resolved

tools/l2t_scaffolder.py Outdated Show resolved Hide resolved

kiddinn added 2 commits November 20, 2018 08:57

bumping version

1c679ab

deleting unneeded cli code.

e5d59e4

kiddinn requested a review from Onager November 20, 2018 17:00

Changes after review

59d276a

Onager requested changes Nov 21, 2018

View reviewed changes

kiddinn added 2 commits November 21, 2018 03:19

responding to code review.

7513a0d

some merge issues

d361b26

kiddinn requested a review from Onager November 21, 2018 11:24

Onager added 3 commits November 21, 2018 14:29

Changes after review

2506057

Make tests pass

1888729

Rename method to match style guide

2dd2fca

Onager requested changes Nov 21, 2018

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

Onager and others added 2 commits November 21, 2018 14:57

Update test string

a163fa7

Removing timeout from tests.

72a8026

kiddinn requested a review from Onager November 21, 2018 15:07

Onager approved these changes Nov 21, 2018

View reviewed changes

Onager merged commit a0ea2f5 into log2timeline:master Nov 21, 2018

scaffolder v2 automation moved this from In Review to Completed Nov 21, 2018

kiddinn deleted the cli_cl branch November 21, 2018 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create the frontend to the scaffolder project #40

Create the frontend to the scaffolder project #40

kiddinn commented Oct 20, 2018

kiddinn left a comment

kiddinn Nov 12, 2018

kiddinn Nov 12, 2018

kiddinn Nov 12, 2018

kiddinn Nov 12, 2018

kiddinn commented Nov 13, 2018

Onager left a comment

kiddinn left a comment

kiddinn commented Nov 20, 2018

Onager Nov 21, 2018

kiddinn commented Nov 21, 2018

kiddinn commented Nov 21, 2018

Create the frontend to the scaffolder project #40

Create the frontend to the scaffolder project #40

Conversation

kiddinn commented Oct 20, 2018

kiddinn left a comment

Choose a reason for hiding this comment

kiddinn Nov 12, 2018

Choose a reason for hiding this comment

kiddinn Nov 12, 2018

Choose a reason for hiding this comment

kiddinn Nov 12, 2018

Choose a reason for hiding this comment

kiddinn Nov 12, 2018

Choose a reason for hiding this comment

kiddinn commented Nov 13, 2018

Onager left a comment

Choose a reason for hiding this comment

kiddinn left a comment

Choose a reason for hiding this comment

kiddinn commented Nov 20, 2018

Onager Nov 21, 2018

Choose a reason for hiding this comment

kiddinn commented Nov 21, 2018

kiddinn commented Nov 21, 2018