-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a scaffolder for Turbinia jobs #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 80.8% 81.64% +0.83%
==========================================
Files 27 29 +2
Lines 969 1035 +66
==========================================
+ Hits 783 845 +62
- Misses 186 190 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, but I think @aarontp should approve too.
Cool! Should we maybe have this generate the Task template at the same time? @kiddinn: You've probably seen this already, but here's the docs on how to create a Job/Task right now: For most of the current Jobs and Tasks, there is a 1:1 Job:Task mapping (e.g. 1 PlasoJob -> 1 PlasoTask), but we're starting to create and plan for more complex Jobs/Tasks that split up the Jobs into multiple Tasks. There's a little more documentation on Jobs vs. Tasks here: https://github.com/google/turbinia/blob/master/docs/how-it-works.md |
wIll add a task file generation to this scaffolder as well |
Minor changes to the scaffolder issue request template
Minor update to the bugreport template
I've asked @aarontp to take another look as well, but I added the task generation and renamed files. Ready for another round. |
need to rebase and add minor corrections after the push of init file changes got pushed in |
again, a bunch of other files got mangled in, closing this PR and opening a new one |
Adding a new scaffolder to generate jobs for Turbinia, part of #49