Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a scaffolder for Turbinia jobs #56

Closed
wants to merge 20 commits into from

Conversation

kiddinn
Copy link
Member

@kiddinn kiddinn commented Nov 23, 2018

Adding a new scaffolder to generate jobs for Turbinia, part of #49

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #56 into master will increase coverage by 0.83%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage    80.8%   81.64%   +0.83%     
==========================================
  Files          27       29       +2     
  Lines         969     1035      +66     
==========================================
+ Hits          783      845      +62     
- Misses        186      190       +4
Impacted Files Coverage Δ
l2tscaffolder/scaffolders/__init__.py 100% <100%> (ø) ⬆️
l2tscaffolder/scaffolders/turbinia_job_task.py 100% <100%> (ø)
l2tscaffolder/scaffolders/turbinia.py 92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb162c...6191aab. Read the comment docs.

Copy link
Contributor

@Onager Onager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but I think @aarontp should approve too.

@aarontp
Copy link

aarontp commented Nov 27, 2018

Cool! Should we maybe have this generate the Task template at the same time?

@kiddinn: You've probably seen this already, but here's the docs on how to create a Job/Task right now:
https://github.com/google/turbinia/blob/master/docs/developing-new-tasks.md

For most of the current Jobs and Tasks, there is a 1:1 Job:Task mapping (e.g. 1 PlasoJob -> 1 PlasoTask), but we're starting to create and plan for more complex Jobs/Tasks that split up the Jobs into multiple Tasks. There's a little more documentation on Jobs vs. Tasks here: https://github.com/google/turbinia/blob/master/docs/how-it-works.md

@kiddinn
Copy link
Member Author

kiddinn commented Nov 27, 2018

wIll add a task file generation to this scaffolder as well

@kiddinn kiddinn requested a review from Onager November 28, 2018 15:26
@kiddinn
Copy link
Member Author

kiddinn commented Nov 28, 2018

I've asked @aarontp to take another look as well, but I added the task generation and renamed files. Ready for another round.

@kiddinn
Copy link
Member Author

kiddinn commented Nov 28, 2018

need to rebase and add minor corrections after the push of init file changes got pushed in

@kiddinn
Copy link
Member Author

kiddinn commented Nov 28, 2018

again, a bunch of other files got mangled in, closing this PR and opening a new one

@kiddinn kiddinn closed this Nov 28, 2018
@kiddinn kiddinn deleted the tur_scaffolder branch December 3, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants