Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

end-to-end tests Greendale acserver image timing out #3153

Closed
joachimmetz opened this issue Jul 7, 2020 · 2 comments · Fixed by #3154
Closed

end-to-end tests Greendale acserver image timing out #3153

joachimmetz opened this issue Jul 7, 2020 · 2 comments · Fixed by #3154
Assignees
@joachimmetz
Labels
parsers Issues related to parsers and parser plug-ins testing
Milestone
2020 July release

Comments

@joachimmetz
Copy link
Member

The end-to-end tests for the Greendale acserver image are timing out. This appears to be related to the pls_recall parser. When enabled the workers time out, when disabled processing seems to continue running smootly.
@joachimmetz joachimmetz self-assigned this Jul 7, 2020
@joachimmetz joachimmetz added parsers Issues related to parsers and parser plug-ins testing labels Jul 7, 2020
@joachimmetz
Copy link
Member Author

joachimmetz commented Jul 8, 2020 •
edited

plaso/plaso/parsers/pls_recall.py

Line 80 in 1d320c7

pls_year, _, _ = pls_date_time.GetDate()
is taking a long time likely due to an invalid date time value

joachimmetz added a commit to joachimmetz/plaso that referenced this issue Jul 8, 2020
@joachimmetz
Changes to PLS recall parser format validation log2timeline#3153
6e7730e
@joachimmetz joachimmetz added the close after review Issue as outstanding pull request(s) and can be closed once these have been reviewed and merged label Jul 8, 2020
@joachimmetz joachimmetz mentioned this issue Jul 8, 2020
Merged
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Jul 8, 2020
@joachimmetz
Changes to PLS recall parser format validation log2timeline#3153
fd90680
@joachimmetz
Copy link
Member Author

Added some additional sanity checks #3154

@joachimmetz joachimmetz mentioned this issue Jul 8, 2020
Closed
@joachimmetz joachimmetz added this to the 2020 August release milestone Jul 8, 2020
@joachimmetz joachimmetz linked a pull request Jul 8, 2020 that will close this issue
Changes to PLS recall parser format validation #3153 #3154
Merged
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Jul 10, 2020
@joachimmetz
Changes to PLS recall parser format validation log2timeline#3153
b13046b
joachimmetz added a commit that referenced this issue Jul 10, 2020
@joachimmetz
Changes to PLS recall parser format validation #3153 (#3154)
c8ed8c5
@joachimmetz joachimmetz removed the close after review Issue as outstanding pull request(s) and can be closed once these have been reviewed and merged label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmetz joachimmetz

Labels
parsers Issues related to parsers and parser plug-ins testing
Projects
None yet
Milestone
2020 July release
Development

Successfully merging a pull request may close this issue.

Changes to PLS recall parser format validation #3153 joachimmetz/plaso
1 participant
@joachimmetz