Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARTIFACT_GROUP support for image_export.py #2166

Merged
merged 5 commits into from Oct 11, 2018

Conversation

rbdebeer-zz
Copy link

@rbdebeer-zz rbdebeer-zz commented Oct 3, 2018

One line description of pull request

Adds support to export ARTIFACT_GROUP artifacts to image_export.py

Description:

Adds support to export ARTIFACT_GROUP artifacts to image_export.py. Please pay attention as I moved
the 'find_specs_per_source_type' from function local to class variable!

Related issue (if applicable): fixes #2015

Notes:

All contributions to Plaso undergo code
review
. This makes sure
that the code has appropriate test coverage and conforms to the Plaso style
guide
.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (Travis, Codecov, Codefactor )pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

@joachimmetz joachimmetz self-assigned this Oct 3, 2018
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #2166 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage   85.14%   85.15%   +0.01%     
==========================================
  Files         455      455              
  Lines       32037    32046       +9     
==========================================
+ Hits        27277    27290      +13     
+ Misses       4760     4756       -4
Impacted Files Coverage Δ
plaso/engine/artifact_filters.py 91.76% <100%> (+3.6%) ⬆️
plaso/cli/image_export_tool.py 83.12% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437c4db...47abf91. Read the comment docs.

Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, let's chat more about the need for a instance attribute and your thoughts for a cleaner approach.

tests/cli/image_export_tool.py Outdated Show resolved Hide resolved
plaso/engine/artifact_filters.py Outdated Show resolved Hide resolved
plaso/engine/artifact_filters.py Outdated Show resolved Hide resolved
plaso/engine/artifact_filters.py Outdated Show resolved Hide resolved
tests/cli/image_export_tool.py Outdated Show resolved Hide resolved
@rbdebeer-zz
Copy link
Author

PTAL

@joachimmetz joachimmetz self-requested a review October 4, 2018 17:26
Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sry for the delay in review

@joachimmetz joachimmetz merged commit e6d449b into log2timeline:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ARTIFACT_GROUP artifact type
2 participants