New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARTIFACT_GROUP support for image_export.py #2166
Add ARTIFACT_GROUP support for image_export.py #2166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
+ Coverage 85.14% 85.15% +0.01%
==========================================
Files 455 455
Lines 32037 32046 +9
==========================================
+ Hits 27277 27290 +13
+ Misses 4760 4756 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits, let's chat more about the need for a instance attribute and your thoughts for a cleaner approach.
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sry for the delay in review
One line description of pull request
Adds support to export ARTIFACT_GROUP artifacts to image_export.py
Description:
Adds support to export ARTIFACT_GROUP artifacts to image_export.py. Please pay attention as I moved
the 'find_specs_per_source_type' from function local to class variable!
Related issue (if applicable): fixes #2015
Notes:
All contributions to Plaso undergo code
review. This makes sure
that the code has appropriate test coverage and conforms to the Plaso style
guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: