Added support for Firefox Cookie SQLite schema version 10 #4664 #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4665 +/- ##
==========================================
+ Coverage 85.81% 85.82% +0.01%
==========================================
Files 412 412
Lines 35476 35483 +7
==========================================
+ Hits 30442 30453 +11
+ Misses 5034 5030 -4
☔ View full report in Codecov by Sentry. |
joachimmetz
reviewed
May 24, 2023
joachimmetz
reviewed
May 25, 2023
| @@ -175,5 +153,61 @@ def ParseCookieRow(self, parser_mediator, query, row, **unused_kwargs): | |||
|
|
|||
| self._ParseCookie(parser_mediator, cookie_name, cookie_data, url) | |||
|
|
|||
| class FirefoxCookie2Plugin(BaseFirefoxCookiePlugin): | |||
| ''' | |||
There was a problem hiding this comment.
please use """ to keep the codebase consistent
joachimmetz
reviewed
May 25, 2023
joachimmetz
reviewed
May 25, 2023
| 'path, appId, inBrowserElement))')}] | ||
|
|
||
| sqlite.SQLiteParser.RegisterPlugins([FirefoxCookie2Plugin, FirefoxCookie10Plugin]) | ||
|
|
There was a problem hiding this comment.
remove trailing empty lines
|
Let's also add a unit test for FirefoxCookie10Plugin |
joachimmetz
reviewed
May 25, 2023
joachimmetz
reviewed
May 25, 2023
|
docs linter is flagging a concern, I'll remove the anchor |
joachimmetz
changed the title
|
Make some style and linting related changes and tests are passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of pull request
Firefox cookie table schema has been upgraded to remove baseDomain. Removed baseDomain from the required keys
Description:
fixes #4664
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: