Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include "typings" field in package.json #339

Closed
rolandjitsu opened this issue Nov 30, 2015 · 5 comments
Closed

include "typings" field in package.json #339

rolandjitsu opened this issue Nov 30, 2015 · 5 comments

Comments

@rolandjitsu
Copy link

Now that the TS compiler supports module resolution via node, it would be nice not to use TSD to install the typing but instead have them included with the npm package.

@lambrojos
Copy link

+1

@nomiddlename
Copy link
Collaborator

That's a really long conversation to get my head around, especially as I know nothing about Typescript. Is there a summary page? A "what you need to do to your package.json" version of it? If someone who knows more than me wants to submit a PR, I'd be happy to look at it.

@rolandjitsu
Copy link
Author

@nomiddlename you can take a look at typings for seeing how to edit the package.json, and the official doc Typings-for-npm-packages.

@a8775
Copy link

a8775 commented Mar 18, 2016

+1

@a8775
Copy link

a8775 commented Mar 18, 2016

There is a file close to be ready:

https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/7554cff7c4dd34decc2f3dc0d711a6c288174eee/log4js/log4js.d.ts

It works for me after stripping all "express" references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants