Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Donot create appender if not used #1002

Merged
merged 2 commits into from May 24, 2020
Merged

Donot create appender if not used #1002

merged 2 commits into from May 24, 2020

Conversation

rnd-debug
Copy link
Contributor

Related to #1000 . The fix will check if an appender exists in a category before trying to create it.

@rnd-debug
Copy link
Contributor Author

rnd-debug commented May 3, 2020 •
edited

Interesting: fails on test/tap/server-test.js (not modified by the commits) with :

✖ connect ECONNREFUSED 127.0.0.1:5678

Any idea why?

@nomiddlename nomiddlename added this to the 6.3.0 milestone May 24, 2020
@nomiddlename nomiddlename merged commit 4b0c6f4 into log4js-node:master May 24, 2020
@nomiddlename
Copy link
Collaborator

Fix published in log4js@6.3.0 - the ECONNREFUSED error was due to the tcp-server appender not being started, it just listens for tcp messages and forwards them to other appenders so it does not need a category assigned. I hacked in a dodgy fix for it.

@rnd-debug rnd-debug deleted the donot-create-appender-if-not-used branch May 30, 2020 08:58
@rnd-debug
Copy link
Contributor Author

Thank you for the feedback!

@lamweili lamweili linked an issue Jan 5, 2022 that may be closed by this pull request
File appenders try to open files even though they do not exist in a category #1000
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

File appenders try to open files even though they do not exist in a category
2 participants
@rnd-debug @nomiddlename