chore(test): improve test coverage #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appenders/connect-logger.js - Line 279 - return;
This was referenced Mar 10, 2022
appenders/file.js - Line 65 - return; appenders/dateFile.js - Line 45 - return;
lib/logger.js - Line 25 - catch (err) {
lib/logger.js - Line 26 - // will never get error unless nodejs has breaking changes to Error
lib/logger.js - Line 27 - console.error('log4js.logger - defaultParseCallStack error', err); // eslint-disable-line no-console
lib/logger.js - Line 28 - }
lib/logger.js - Line 29 - return null;
used a simpler compare function to avoid branch coverage issues in fileSync.js
removed redundant default value for EOL to avoid branch coverage issues in fileSync.js
This was referenced Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Test Coverage (Part 3 of 3)