Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add maxLength to recording - closes #1385 #1386

Merged
merged 2 commits into from Jun 7, 2023
Merged

add maxLength to recording - closes #1385 #1386

merged 2 commits into from Jun 7, 2023

Conversation

gabriel-cloud
Copy link
Contributor

No description provided.

@gabriel-cloud gabriel-cloud changed the title add maxLength to recording add maxLength to recording - closes #1386 May 19, 2023
@gabriel-cloud gabriel-cloud changed the title add maxLength to recording - closes #1386 add maxLength to recording - closes #1385 May 19, 2023
@gabriel-cloud gabriel-cloud mentioned this pull request May 19, 2023
Closed
@lamweili
Copy link
Contributor

Ah, you'll need to change test/tap/recordingAppender-test.js for the test coverage.

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
recording.js 90.9 50 100 90.9 12

After that, it should be all good to go! 🤗

@gabriel-cloud
Copy link
Contributor Author

How's that looking?

@lamweili lamweili added this to the 6.9.2 milestone Jun 7, 2023
@lamweili lamweili added the enhancement New feature or request label Jun 7, 2023
@lamweili lamweili merged commit c5d71e9 into log4js-node:master Jun 7, 2023
15 checks passed
@lamweili lamweili linked an issue Jun 7, 2023 that may be closed by this pull request
Add maxLength to the recording appender #1385
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamweili lamweili lamweili approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.9.2
Development

Successfully merging this pull request may close these issues.

Add maxLength to the recording appender
2 participants
@gabriel-cloud @lamweili