Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies (including eslint) #840

Merged

Conversation

martinheidegger
Copy link
Contributor

I noticed that several of the dependencies are out-of-date. This PR updates the dependencies and fixes linting errors that were an issue after the update.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #840 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          25       25           
  Lines         937      937           
=======================================
  Hits          913      913           
  Misses         24       24
Impacted Files Coverage Δ
lib/layouts.js 95.83% <ø> (ø) ⬆️
lib/log4js.js 98.03% <ø> (ø) ⬆️
lib/appenders/console.js 100% <ø> (ø) ⬆️
lib/appenders/index.js 95.91% <100%> (ø) ⬆️
lib/connect-logger.js 100% <100%> (ø) ⬆️
lib/appenders/fileSync.js 94.73% <100%> (ø) ⬆️
lib/clustering.js 100% <100%> (ø) ⬆️
lib/configuration.js 100% <100%> (ø) ⬆️
lib/appenders/noLogFilter.js 100% <100%> (ø) ⬆️
lib/categories.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8221ada...a06e2cc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #840 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          25       25           
  Lines         937      937           
=======================================
  Hits          913      913           
  Misses         24       24
Impacted Files Coverage Δ
lib/layouts.js 95.83% <ø> (ø) ⬆️
lib/log4js.js 98.03% <ø> (ø) ⬆️
lib/appenders/console.js 100% <ø> (ø) ⬆️
lib/appenders/index.js 95.91% <100%> (ø) ⬆️
lib/connect-logger.js 100% <100%> (ø) ⬆️
lib/appenders/fileSync.js 94.73% <100%> (ø) ⬆️
lib/clustering.js 100% <100%> (ø) ⬆️
lib/configuration.js 100% <100%> (ø) ⬆️
lib/appenders/noLogFilter.js 100% <100%> (ø) ⬆️
lib/categories.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8221ada...a06e2cc. Read the comment docs.

@nomiddlename nomiddlename added this to the Next release milestone Feb 20, 2019
@nomiddlename
Copy link
Collaborator

Thanks for this. Much appreciated.

@nomiddlename nomiddlename merged commit 675dfd9 into log4js-node:master Feb 20, 2019
@martinheidegger martinheidegger deleted the update-dependencies branch February 20, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants