Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sighup handler was just nonsense #873

Merged
merged 1 commit into from May 8, 2019
Merged

Conversation

nomiddlename
Copy link
Collaborator

The streamroller upgrade in version 4 removed a couple of functions that the signup handler used, but the test had mock versions so nothing broke.

This PR fixes #847

@nomiddlename nomiddlename added this to the 4.2.0 milestone May 8, 2019
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          25       25           
  Lines         968      968           
=======================================
  Hits          949      949           
  Misses         19       19
Impacted Files Coverage Δ
lib/appenders/file.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db95a9d...542daa4. Read the comment docs.

@nomiddlename nomiddlename merged commit ff198de into master May 8, 2019
@nomiddlename nomiddlename deleted the fix-sighup-handler branch May 8, 2019 22:32
@nomiddlename
Copy link
Collaborator Author

Published to NPM in version 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError thrown in writer.openTheStream.bind(writer)
1 participant