Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for appender passing #904

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Docs for appender passing #904

merged 2 commits into from
Jun 25, 2019

Conversation

nomiddlename
Copy link
Collaborator

Added some documentation that nobody will ever read, so that I can say "did you read the docs?" when they raise issues.

@kaxelson if you could take a quick look to confirm that it matches up with your pull request that would be great. I'll merge it anyway, so as not to delay the release - we can always fix up errors in the docs later.

@nomiddlename nomiddlename added this to the 4.4.0 milestone Jun 25, 2019
@nomiddlename nomiddlename merged commit 399096c into master Jun 25, 2019
@nomiddlename nomiddlename deleted the docs-for-appender-passing branch June 25, 2019 22:12
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e0abff4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #904   +/-   ##
=========================================
  Coverage          ?   97.98%           
=========================================
  Files             ?       25           
  Lines             ?      995           
  Branches          ?        0           
=========================================
  Hits              ?      975           
  Misses            ?       20           
  Partials          ?        0
Impacted Files Coverage Δ
lib/appenders/index.js 98.07% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0abff4...7b4cfbe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant