Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling files ignore initial file last modified time #36

Closed
nomiddlename opened this issue Apr 2, 2019 · 1 comment
Closed

Rolling files ignore initial file last modified time #36

nomiddlename opened this issue Apr 2, 2019 · 1 comment
Milestone
1.0.5

Comments

@nomiddlename
Copy link
Collaborator

See log4js-node/log4js-node#838

When rolling by time, if there is an existing file from a previous period (and we are not using the alwaysIncludePattern flag), then that file will be appended to instead of being rolled to a backup. For example:
Initial state.

something.log.2015-05-05
something.log

App is stopped on 2015-05-06. App restarts on 2015-05-07.

Expected:

something.log.2015-05-05
something.log.2015-05-06 // something.log ---> renamed 
something.log // contains log messages from 2015-05-07

Actual:

something.log.2015-05-05
something.log // contains log messages from 2015-05-06 and 07
@nomiddlename nomiddlename added this to the 1.0.5 milestone May 8, 2019
@nomiddlename nomiddlename mentioned this issue May 13, 2019
Merged
@nomiddlename
Copy link
Collaborator Author

Fix published to npm in version 1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.5
Development

No branches or pull requests
1 participant
@nomiddlename