Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dot bug. See log4mongo/log4mongo-java#22 #23

Merged
merged 1 commit into from Feb 14, 2014

Conversation

undso
Copy link

@undso undso commented Feb 13, 2014

Fix for dot bug. See #22

@RobertStewart
Copy link
Collaborator

This pull request has more changes in it then just handling keys that improperly contain dots. Can you please remove the second commit from the pull request so I can merge just the first change?

I'd also like to have a unit test to prove the change works as described. I can always add one after I merge the pull request, or you could add one. Either way works for me.

One thing that surprised me about GitHub is that if you make additional commits on a branch, they automatically get added to any open pull request on that branch. So, I now create feature branches for every change that I plan to submit as a pull request. Then, I can much more easily control which commits end up in a pull request.

@undso
Copy link
Author

undso commented Feb 14, 2014

Yes that is exactly my problem now. The 2nd commit was not for this issue. :-( I'll try to remove it from the request.

@undso
Copy link
Author

undso commented Feb 14, 2014

OK, I revert the commit so the pull is now possible. It would be great if you can add a unit test.

RobertStewart added a commit that referenced this pull request Feb 14, 2014
@RobertStewart RobertStewart merged commit 5ae0a5b into log4mongo:master Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants