Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling issue in screening code #37

Merged
merged 6 commits into from Sep 22, 2023
Merged

Fix scaling issue in screening code #37

merged 6 commits into from Sep 22, 2023

Conversation

loganbvh
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #37 (384b95d) into main (c7d75dc) will increase coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   89.33%   89.39%   +0.05%     
==========================================
  Files          35       35              
  Lines        3808     3810       +2     
==========================================
+ Hits         3402     3406       +4     
+ Misses        406      404       -2     
Files Changed Coverage Δ
tdgl/solution/solution.py 88.28% <ø> (ø)
tdgl/visualization/io.py 96.96% <ø> (ø)
tdgl/solver/solve.py 75.81% <81.25%> (+0.53%) ⬆️
tdgl/finite_volume/mesh.py 95.45% <100.00%> (ø)
tdgl/version.py 85.71% <100.00%> (ø)

... and 1 file with indirect coverage changes

@loganbvh loganbvh marked this pull request as ready for review September 22, 2023 01:20
@loganbvh loganbvh merged commit 09d5e25 into main Sep 22, 2023
8 of 9 checks passed
@loganbvh loganbvh deleted the screening-bug branch September 22, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant