Denormalizing using inverse_of #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is the superior to my fix. I missed |
|
Thank you! I probably should have make the ancillary changes (the query speed up thing) on a new other branch, it would have been cleaner. But I hope this pull request will be accepted though. |
|
|
||
| chgs = assigns.inject({}){ |m,(k,v)| m["#{prefix}_#{k}"]= v; m } | ||
|
|
||
| if association_s == association_s.pluralize |
There was a problem hiding this comment.
I am working on getting this PR updated with the latest code. I'm probably going to change this line though. I'm not sure that relying on the inflections to determine whether an association is a "many" is better than checking the macro of the relation.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I also met the same issue refered in this pull request, but I did not solved this using the same way. I prefered to use mongoid native
inverse_ofinstead.