Improve flow types #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `Generator<...>` is the return type of a generator function, not the generator itself
2. Add an `Args` type parameter, so that it's possible to specify arguments type in a way
that works both inside and outside the `gensync` call:
```js
var fn = gensync<[number, number], string>(function* (x, y) { return "" });
```
|
Ok, I didn't understand the |
|
Note that this typings don't play well with variadic functions, since a tuple has a fixed length, but except for a few cases are working well for |
3 tasks
loganfsmyth
reviewed
Sep 28, 2019
| } & ( | ||
| | { async(...args: Args): Promise<Return> } | ||
| // ...args: [...Args, Callback] | ||
| | { errback(...args: any[]): void } |
There was a problem hiding this comment.
Technically these are both optional too. Does | {} also work here? I have no idea if Flow can handle that.
There was a problem hiding this comment.
At the moment it uses the sync function if neither are provided.
There was a problem hiding this comment.
| {} doesn't work because it isn't an exact object, and if it was we couldn't use &.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generator<...>is the return type of a generator function, not the generator itselfAdd an
Argstype parameter, so that it's possible to specify arguments type in a waythat works both inside and outside the
gensynccall:I had to use
anybecause withmixedI got errors about it not being compatible with the types of the generator function.