Merge branch 'jasondavies-new_closure_compiler' into mbostock-master

Makefile

@@ -136,6 +136,7 @@ d3.geom.js: \
 tests: \
 	tests/test-append.test \
 	tests/test-attr.test \
+	tests/test-call.test \
 	tests/test-format.test \
 	tests/test-transition.test \
 	tests/test-scale-linear.test \

d3.js

@@ -195,10 +195,19 @@ function d3_splitter(d) {
 function d3_collapse(s) {
   return s.replace(/(^\s+)|(\s+$)/g, "").replace(/\s+/g, " ");
 }
+//
+// Note: assigning to the arguments array simultaneously changes the value of
+// the corresponding argument! However, the Google Closure compiler doesn't
+// realize this, and so can optimize-away our attempt to avoid side-effects.
+// This fix by Jason Davies has been tested to survive minimization.
+//
+// TODO The `this` argument probably shouldn't be the first argument to the
+// callback, anyway, since it's redundant. However, that will require a major
+// version bump due to backwards compatibility, so I'm not changing it right
+// away.
+//
 function d3_call(callback) {
-  var f = callback;
-  arguments[0] = this;
-  f.apply(this, arguments);
+  callback.apply(this, (arguments[0] = this, arguments));
   return this;
 }
 /**