feat: cache all the vee-validate event handlers on the provider instance

logaretm · Sep 18, 2019 · 6dc9fad · 6dc9fad
1 parent 515fe7b
commit 6dc9fad
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/src/components/Provider.ts b/src/components/Provider.ts
@@ -21,6 +21,8 @@ type withProviderPrivates = VueConstructor<
     _veeWatchers: Record<string, Function>;
     $veeDebounce?: number;
     $veeHandler?: Function;
+    $veeOnInput?: Function;
+    $veeOnBlur?: Function;
     $vnode: VNodeWithVeeContext;
   }
 >;

diff --git a/src/components/common.ts b/src/components/common.ts
@@ -102,15 +102,23 @@ export function computeModeSetting(ctx: ProviderInstance) {
 
 // Creates the common handlers for a validatable context.
 export function createCommonHandlers(vm: ProviderInstance) {
-  const onInput = (e: any) => {
-    vm.syncValue(e); // track and keep the value updated.
-    vm.setFlags({ dirty: true, pristine: false });
-  };
+  if (!vm.$veeOnInput) {
+    vm.$veeOnInput = (e: any) => {
+      vm.syncValue(e); // track and keep the value updated.
+      vm.setFlags({ dirty: true, pristine: false });
+    };
+  }
+
+  const onInput = vm.$veeOnInput;
+
+  if (!vm.$veeOnBlur) {
+    vm.$veeOnBlur = () => {
+      vm.setFlags({ touched: true, untouched: false });
+    };
+  }
 
   // Blur event listener.
-  const onBlur = () => {
-    vm.setFlags({ touched: true, untouched: false });
-  };
+  const onBlur = vm.$veeOnBlur;
 
   let onValidate = vm.$veeHandler;
   const mode = computeModeSetting(vm);