feat(breaking): disable v-model support by default closes #4283

logaretm · May 31, 2023 · 7ce9d67 · 7ce9d67
1 parent 75216dd
commit 7ce9d67
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/fifty-weeks-eat.md b/.changeset/fifty-weeks-eat.md
@@ -0,0 +1,5 @@
+---
+'vee-validate': minor
+---
+
+feat(breaking): disable v-model support by default closes #4283
diff --git a/packages/vee-validate/src/Field.ts b/packages/vee-validate/src/Field.ts
@@ -147,6 +147,7 @@ const FieldImpl = /** #__PURE__ */ defineComponent({
       label,
       validateOnValueUpdate: false,
       keepValueOnUnmount: keepValue,
+      syncVModel: true,
     });
 
     // If there is a v-model applied on the component we need to emit the `update:modelValue` whenever the value binding changes

diff --git a/packages/vee-validate/src/useField.ts b/packages/vee-validate/src/useField.ts
@@ -453,7 +453,7 @@ function normalizeOptions<TValue>(opts: Partial<FieldOptions<TValue>> | undefine
     validateOnValueUpdate: true,
     keepValueOnUnmount: undefined,
     modelPropName: 'modelValue',
-    syncVModel: true,
+    syncVModel: false,
     controlled: true,
   });
 

diff --git a/packages/vee-validate/tests/Form.spec.ts b/packages/vee-validate/tests/Form.spec.ts
@@ -2814,6 +2814,7 @@ describe('<Form />', () => {
           type: 'checkbox',
           uncheckedValue: false,
           checkedValue: true,
+          syncVModel: true,
         });
 
         return {

diff --git a/packages/vee-validate/tests/useField.spec.ts b/packages/vee-validate/tests/useField.spec.ts
@@ -561,7 +561,7 @@ describe('useField()', () => {
         modelValue: String,
       },
       setup() {
-        const { value, errorMessage } = useField('field');
+        const { value, errorMessage } = useField('field', undefined, { syncVModel: true });
 
         return {
           value,
@@ -691,6 +691,7 @@ describe('useField()', () => {
       setup() {
         const { value, errorMessage } = useField('field', undefined, {
           modelPropName: 'textVal',
+          syncVModel: true,
         });
 
         return {