fix: handle NaN when parsing number inputs closes #4328

logaretm · Jun 23, 2023 · fc41691 · fc41691
1 parent 435e785
commit fc41691
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/neat-phones-crash.md b/.changeset/neat-phones-crash.md
@@ -0,0 +1,5 @@
+---
+'vee-validate': patch
+---
+
+fix: handle NaN when parsing number inputs closes #4328
diff --git a/packages/vee-validate/src/utils/events.ts b/packages/vee-validate/src/utils/events.ts
@@ -3,7 +3,7 @@ import { getBoundValue, hasValueBinding } from './vnode';
 
 function parseInputValue(el: HTMLInputElement) {
   if (el.type === 'number') {
-    return el.valueAsNumber;
+    return Number.isNaN(el.valueAsNumber) ? el.value : el.valueAsNumber;
   }
 
   return el.value;

diff --git a/packages/vee-validate/tests/useField.spec.ts b/packages/vee-validate/tests/useField.spec.ts
@@ -892,6 +892,10 @@ describe('useField()', () => {
     setValue(input, '123');
     await flushPromises();
     expect(field.value.value).toBe(123);
+
+    setValue(input, '');
+    await flushPromises();
+    expect(field.value.value).toBe('');
   });
 
   test('a validator can return multiple messages', async () => {