Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url validation rule doesnt work #156

Closed
terrylow opened this issue Nov 30, 2016 · 5 comments
Closed

url validation rule doesnt work #156

terrylow opened this issue Nov 30, 2016 · 5 comments

Comments

@terrylow
Copy link

Versions:

  • VueJs: 2.1.3
  • Vee-Validate:2.0.0-beta.16

Description:

url validation rules doesnt seem to work correctly

Steps To Reproduce:

kindly refer to jsfiddle

thx

@BrandonSurowiec
Copy link
Contributor

@logaretm We can force the http(s)/ftp:: protocol with the require_protocol: true option, but not sure why some of the other urls are not passing. Ideas?

@logaretm
Copy link
Owner

logaretm commented Nov 30, 2016

@BrandonSurowiec It happens because of the whitelist, seems like I've made a mistake while setting the default.

We can enforce the protocol or provide a parameter that does so, depending on the user needs, what do you think?

logaretm added a commit that referenced this issue Dec 3, 2016
@cargie
Copy link

cargie commented Dec 3, 2016

shouldnt url validation require protocol by default or can we make some options to require protocol or not?

@logaretm
Copy link
Owner

logaretm commented Dec 3, 2016

I guess we can require the protocol and provide an option to make it optional.

@BrandonSurowiec what do you think?

@BrandonSurowiec
Copy link
Contributor

BrandonSurowiec commented Dec 3, 2016

I think we should always require the protocol like Laravel does. We could make another rule called 'domain' or for now leave it up to the developer to customize with their own custom rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants