Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] ValidationProvider checkbox doesn't validate #1900

Closed
exodusanto opened this issue Mar 5, 2019 · 2 comments · Fixed by #1913
Closed

[2.6] ValidationProvider checkbox doesn't validate #1900

exodusanto opened this issue Mar 5, 2019 · 2 comments · Fixed by #1913
Labels
🐛 bug Unintended behavior

Comments

@exodusanto
Copy link
Contributor

Versions

  • vee-validate: 2.1.7
  • vue: 2.6.8

Describe the bug
If I use Vue 2.6 checkbox input doesn't works instead with 2.5 the validation works

To reproduce
Steps to reproduce the behavior:

  1. Click on 'native checkbox and check/uncheck it'
  2. Use Vue 2.5
  3. Click on 'native checkbox and check/uncheck it'

Expected behavior
Show error and invalid flag if checkbox is not filled

Demo link
Codesandbox.

Desktop (please complete the following information):

  • OS: OSX
  • Browser chrome
  • Version 72.x
@logaretm logaretm added the 🐛 bug Unintended behavior label Mar 11, 2019
logaretm added a commit that referenced this issue Mar 11, 2019
fix: event value mismatch with model value for checkboxes  (fix #1900)
@logaretm
Copy link
Owner

Thanks for reporting this, this was due checkboxes having a value of "on" when the change event is triggered causing the event validation to validate it as valid most of the time. This was fixed and will be available in the next release soon.

@GreggOD
Copy link

GreggOD commented Apr 2, 2019

From 2.17 to 2.20 are some serious breaking changes for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants