Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect Confirmed Rule only working when enter the confirmed input #1902

Closed
JackFGreen opened this issue Mar 6, 2019 · 2 comments · Fixed by #1915
Closed

Expect Confirmed Rule only working when enter the confirmed input #1902

JackFGreen opened this issue Mar 6, 2019 · 2 comments · Fixed by #1915
Labels
✨ enhancement a "nice to have" feature

Comments

@JackFGreen
Copy link

Expect confirmed rule should not wok when enter the email input.

image
@logaretm logaretm added the ✨ enhancement a "nice to have" feature label Mar 6, 2019
@logaretm
Copy link
Owner

logaretm commented Mar 6, 2019

Currently, the confirmed rule triggers validation on the target fields as well, This behavior should be changed to only do that when the confirmed input has been interacted with or the form is being manually validated with validator.validate()

@JackFGreen
Copy link
Author

@logaretm Yes, here is a similar problem #1912 , the validation should trigger by interaction or validator.validate()

@logaretm logaretm mentioned this issue Mar 11, 2019
Merged
logaretm added a commit that referenced this issue Mar 11, 2019
@logaretm
Feat cross field validation behavior (#1915)
0a543c1 
This PR forces the validation provider and the directive to not validate the cross-field targets until they have been interacted with or if validation was triggered manually at least once.

This solves the "aggressive" behavior when the user has only interacted with one of the two confirmed inputs for the first time.

closes #1902, closes #1869, closes #1765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement a "nice to have" feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat cross field validation behavior
2 participants
@logaretm @JackFGreen