Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If required on the HTML element input is false the resolveRules marks it as required #2314

Closed
erwineverts opened this issue Sep 10, 2019 · 1 comment · Fixed by #2315
Closed

Comments

@erwineverts
Copy link
Contributor

{
  data: () => ({ val: '1' }),
  template: `
    <ValidationProvider v-slot="{ errors }">
      <input type="text" :required="false" v-model="val">
        <p id="error">{{ errors[0] }}</p>
       </ValidationProvider>
    `
}

The expected behaviour is that the element is not required, currently it is.

{
  data: () => ({ val: '1' }),
  template: `
    <ValidationProvider v-slot="{ errors }">
      <input type="text" required v-model="val">
        <p id="error">{{ errors[0] }}</p>
       </ValidationProvider>
    `
}

Should still make the input field required

Our item is a wrapper with styling to the form elements

@erwineverts
Copy link
Contributor Author

I'll make a PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant