$validator.validateAll() started to resolve positive all the time in 2.0.0-rc.12

[Gotterbild]

Versions:

• VueJs: 2.4.2
• Vee-Validate: 2.0.0-rc.12

Description:

Everything worked with 2.0.0-rc.3

After upgrading to 2.0.0-rc.12 $validator.validateAll() started to resolve positive all the time.

Expected behavior and how it works with 2.0.0-rc.3:

1. I click a button
2. $validator.validateAll() ignores then section and goes to catch section.
3. Validation errors appear for invalid fields (through :class="{show: errors.has('password:required')}")

How it works with 2.0.0-rc.12:

1. I click a button
2. Validation errors appear. So, validator seems to validate, BUT
3. $validator.validateAll() fires then section and never runs catch section

When I downgrade to 2.0.0-rc.3 app works as expected.

Steps To Reproduce:

Run the fiddle: https://jsfiddle.net/v4ejau4e/2/

[logaretm]

You should read the release notes, the validator no longer throws an exception when validation fails, because technically it is an expected result. this is discussed here #507

Basically it hides the real reason behind the rejection, which could include an app error not just the validator error. Now the validator returns the result as a boolean in the then callback.

page.$validator.validateAll()
  .then(function (result) {
    if (result) {
      // all good
    } else {
      // validation failed.
    }
  })
  .catch(function (error) {
    // something serious has went wrong, not a validation error.
});

I've updated the fiddle:

https://jsfiddle.net/logaretm/v4ejau4e/3/

I'm aware that such breaking changes should respect semver more, but that is why we are still at rc so we can improve the library before getting the first release, which then would respect semver more. Sorry about that.

[Gotterbild]

Thanks! Sorry, but I didn't read the release notes as you just can't check out release notes of every lib you have after you run npm install, especially if you have 50+ libs :)

Usually first idea you have is that it is a bug, not a feature :)

Will read release notes next time.

Thanks for great lib!