Don't use reject for expected outcomes. #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, communicate a falure of validation using a param to resolve. See issue logaretm#506
|
I understand the need for not wanting to catch the exceptions, still what about backward compatibility? I prefer if we can provide an option to let it "soft" reject them using your PR, otherwise it would throw so users can choose which behavior seems reasonable to them. |
|
I have 2 forms on the same page, so I have 2 different scopes and for that I create 2 keys within the date (), AI at that time that happens the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, communicate a failure of validation using a param to resolve.
See issue #506