Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable aria and validity for components #1857

Merged
merged 1 commit into from
Feb 13, 2019
Merged

fix: disable aria and validity for components #1857

merged 1 commit into from
Feb 13, 2019

Conversation

logaretm
Copy link
Owner

This disables aria attributes and validity API for custom components as they are not applicable to them anyways, they cause an issue for IE Edge when trying to resolve a component value upon manual validation.

closes #1854

@logaretm logaretm merged commit 308df1b into logaretm:master Feb 13, 2019
@logaretm logaretm deleted the fix-1854 branch February 13, 2019 23:54
@freitasskeeled
Copy link

Hi,

Just updated to the last version with includes this fix.

With aria being disabled for custom components, you break Vuetify components validation state meaning that aria-invalid is no longer applied to its components. I would suggest adding an option to manually activate the aria setting for custom components.

Sorry for commenting on this issue. If you want, I can open a new one.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE Edge Validation doesn't work after initial validation error
2 participants