Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added NaN check for directive render loops closes #1873 #1880

Merged
merged 2 commits into from
Feb 24, 2019
Merged

fix: added NaN check for directive render loops closes #1873 #1880

merged 2 commits into from
Feb 24, 2019

Conversation

logaretm
Copy link
Owner

closes #1873

@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #1880 into master will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   97.19%   97.15%   -0.04%     
==========================================
  Files          60       60              
  Lines        2243     2249       +6     
  Branches      696      698       +2     
==========================================
+ Hits         2180     2185       +5     
- Misses         57       58       +1     
  Partials        6        6
Impacted Files Coverage Δ
src/utils/index.js 97.63% <83.33%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97645f5...696dfda. Read the comment docs.

@logaretm logaretm merged commit 2e89e32 into logaretm:master Feb 24, 2019
@logaretm logaretm deleted the fix-1873 branch February 24, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Update Loop for Unexpected Validation Rule Parameter
1 participant