Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): class names are not all mandatory #2108

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

cexbrayat
Copy link
Contributor

馃攷 Overview
This PR updates the type of ClassNames to make every field optional.

馃 Code snippets/examples (if applicable)

AFAIK, it is possible to only declare:

Vue.use(VeeValidate, {
  classes: true,
  classNames: {
    invalid: 'is-invalid',
  },
});

without having to declare every classes.
The current typings don't allow that.
The PR makes every class optional, making such a configuration possible.

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #2108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2108   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          62       62           
  Lines        2369     2369           
  Branches      743      743           
=======================================
  Hits         2271     2271           
  Misses         89       89           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 00996c7...c63421e. Read the comment docs.

Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the correction and much appreciated!

@logaretm logaretm merged commit cff08e8 into logaretm:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants