Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal dictionary not resolving message to newly registered rules #2545

Merged
merged 3 commits into from
Dec 13, 2019

Conversation

logaretm
Copy link
Owner

closes #2426

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #2545 into master will increase coverage by 0.1%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2545     +/-   ##
=========================================
+ Coverage   95.67%   95.78%   +0.1%     
=========================================
  Files          50       50             
  Lines        1134     1115     -19     
  Branches      168      166      -2     
=========================================
- Hits         1085     1068     -17     
+ Misses         49       47      -2
Impacted Files Coverage Δ
src/localize.ts 96.77% <100%> (+1.65%) ⬆️
src/extend.ts 87.09% <50%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e97000...a896d60. Read the comment docs.

@logaretm logaretm merged commit 1885524 into master Dec 13, 2019
@logaretm logaretm deleted the fix/internal-dictionary-use-config branch December 13, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom rule: cannot display localized message
1 participant