docs(testing): removed sync mode from vueTestUtils #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed sync mode from vueTestUtils, since (it has been removed)[vuejs/vue-test-utils#1137]. Also add the import of flushPromises(). It took quite some time to find out that it was an external package.
Codecov Report
@@ Coverage Diff @@
## master #2829 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 50 50
Lines 1319 1319
Branches 317 317
=======================================
Hits 1262 1262
Misses 57 57 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imporoves the doc, especially the testing part. I removed sync mode from vueTestUtils, since it has been removed.
I also add the import of flushPromises(). It took quite some time to find out that it was an external package.
The only way I got my tests working is by adding
beforeEach(() => jest.useFakeTimers())at the top of my tests.jest.useFakeTimers()was not sufficient. But I think it's more related to Jest, or my misknowledge of Jest, so I didn't change this part. But I'm willing to if you think it's worth.