Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update best-practices.md #3442

Merged
merged 1 commit into from Aug 13, 2021
Merged

Update best-practices.md #3442

merged 1 commit into from Aug 13, 2021

Conversation

ediaz2
Copy link

@ediaz2 ediaz2 commented Aug 12, 2021

Example of import by yup modules

🔎 Overview

🤓 Code snippets/examples (if applicable)

❌ import { object, string } as yup from 'yup';
✔️ import { object, string } from 'yup';

✔ Issues affected

Update best-practices.md
cc40b0b 
Example of import by yup modules
logaretm
logaretm approved these changes Aug 13, 2021
View reviewed changes
Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@logaretm logaretm merged commit 03d3389 into logaretm:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logaretm logaretm logaretm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ediaz2 @logaretm