Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devtool): add compatibility for UTF character #4265

Merged
merged 1 commit into from May 15, 2023

Conversation

linghaoSu
Copy link
Contributor

@linghaoSu linghaoSu commented May 15, 2023

πŸ”Ž Overview

When I upgraded from 4.5 to 4.9, I found that if I use Unicode characters as name, such as emoji, Chinese characters, and use vue devtools, I get window.btoa error

image

βœ” Issues affected

@codecov-commenter
Copy link

Codecov Report

Merging #4265 (ff7c753) into main (220bbe3) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4265   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          73       73           
  Lines        5751     5751           
  Branches     1092     1092           
=======================================
  Hits         5642     5642           
  Misses        109      109           

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghaoSu linghaoSu marked this pull request as draft May 15, 2023 06:02
@linghaoSu linghaoSu marked this pull request as ready for review May 15, 2023 06:23
Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, nice one! Thank you!

@logaretm logaretm merged commit 2879785 into logaretm:main May 15, 2023
8 checks passed
@linghaoSu linghaoSu deleted the chore/devtools-node-id branch May 16, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants