Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add PURE tags to treeshake components #4266

Merged
merged 1 commit into from May 15, 2023

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented May 15, 2023

πŸ”Ž Overview

This PR adds PURE tags to the components so that when they are not used, they will be treeshaken by Rollup.

Rollup REPL

Vue Router's RouterLink source

πŸ€“ Code snippets/examples (if applicable)

// some code

βœ” Issues affected

Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe this wasn't setup before πŸ€¦β€β™‚οΈ

Thank you!

@logaretm logaretm merged commit 03decc2 into logaretm:main May 15, 2023
6 checks passed
@ydcjeff ydcjeff deleted the treeshake-components branch May 16, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants