Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): add valibot support #4412

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Aug 11, 2023

πŸ”Ž Overview

Add support for valibot in Nuxt

βœ” Issues affected

from this issue #4390

@userquin
Copy link
Contributor Author

we should use a helper function providing the name, rn too verbose, the 3 checkXXX are basically the same

@codecov-commenter
Copy link

Codecov Report

Merging #4412 (fc46acb) into main (5033698) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4412   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          79       79           
  Lines        6139     6139           
  Branches     1168     1168           
=======================================
  Hits         6026     6026           
  Misses        113      113           

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will refactor it later. Thanks for the PR!

@logaretm logaretm merged commit d2cc9bc into logaretm:main Aug 13, 2023
8 checks passed
@userquin userquin deleted the feat-add-nuxt-valibot branch August 13, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants