Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactore more scope tests to use isNullOrUndefined(scope) #857

Merged
merged 1 commit into from Sep 27, 2017

Conversation

danielgranat
Copy link

After allowing 0 scope, I found more places in the code that I neglected.

@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #857 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   95.09%   95.09%   +<.01%     
==========================================
  Files          47       47              
  Lines        1264     1265       +1     
  Branches      404      405       +1     
==========================================
+ Hits         1202     1203       +1     
  Misses         52       52              
  Partials       10       10
Impacted Files Coverage Δ
src/core/validator.js 99.28% <100%> (ø) ⬆️
src/core/field.js 100% <100%> (ø) ⬆️
src/core/generator.js 100% <100%> (ø) ⬆️
src/core/errorBag.js 100% <100%> (ø) ⬆️
src/core/utils.js 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c879f2...132c6ab. Read the comment docs.

@logaretm logaretm merged commit 479371b into logaretm:master Sep 27, 2017
@logaretm
Copy link
Owner

Thanks for the follow up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants