Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombinedError Object property graphqlErrors is undefined #49

Closed
Lappihuan opened this issue Sep 30, 2020 · 2 comments · Fixed by #50
Closed

CombinedError Object property graphqlErrors is undefined #49

Lappihuan opened this issue Sep 30, 2020 · 2 comments · Fixed by #50
Labels
🐛 bug Something isn't working ✨ enhancement New feature or request

Comments

@Lappihuan
Copy link

It appears that the CombinedError Object does not set the graphqlErrors property:
grafik

The actual error is still accessible in the response > body > errors array

Expected behaviour would be that the graphqlErrors property of CombinedError holds a array of GraphQLError objects.

@logaretm
Copy link
Owner

Thanks for reporting this, From what I can tell it's because the status code is 400 as GraphQL spec doesn't care much for status code, and returning 200s even if errors exist is perfectly fine.

However I think villus should be adjusted to handle this as well, as I would imagine it is common to return response codes other than 200

@logaretm logaretm added ✨ enhancement New feature or request 🐛 bug Something isn't working labels Sep 30, 2020
@Lappihuan
Copy link
Author

awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants